Author: smanna12 Date: 2024-07-26T07:27:09-05:00 New Revision: 6e0a913973111926f9fdbd82b72ea640b013167e
URL: https://github.com/llvm/llvm-project/commit/6e0a913973111926f9fdbd82b72ea640b013167e DIFF: https://github.com/llvm/llvm-project/commit/6e0a913973111926f9fdbd82b72ea640b013167e.diff LOG: [Clang][NFC] Remove unnecessary copy (#100688) Reported by Static Analyzer Tool: In Sema::checkIncorrectVTablePointerAuthenticationAttribute(): Using the auto keyword without an & causes the copy of an object of type CXXBaseSpecifier. Added: Modified: clang/lib/Sema/SemaDeclCXX.cpp Removed: ################################################################################ diff --git a/clang/lib/Sema/SemaDeclCXX.cpp b/clang/lib/Sema/SemaDeclCXX.cpp index 1cca8ac9b9343..5782daa041f32 100644 --- a/clang/lib/Sema/SemaDeclCXX.cpp +++ b/clang/lib/Sema/SemaDeclCXX.cpp @@ -10385,7 +10385,7 @@ void Sema::checkIncorrectVTablePointerAuthenticationAttribute( while (1) { assert(PrimaryBase); const CXXRecordDecl *Base = nullptr; - for (auto BasePtr : PrimaryBase->bases()) { + for (const CXXBaseSpecifier &BasePtr : PrimaryBase->bases()) { if (!BasePtr.getType()->getAsCXXRecordDecl()->isDynamicClass()) continue; Base = BasePtr.getType()->getAsCXXRecordDecl(); _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
