aaron.ballman added inline comments.
================
Comment at: lib/Sema/SemaTemplateInstantiateDecl.cpp:322
+ CXXThisScopeRAII ThisScope(*this, ThisContext, /*TypeQuals*/ 0,
+ ND && ND->isCXXInstanceMember());
+
----------------
No need to check for `ND` here; already done above. You might also want to
remove `ThisContext` and just sink the initialization.
================
Comment at: utils/TableGen/ClangAttrEmitter.cpp:2520
+ << " const MultiLevelTemplateArgumentList &TemplateArgs) {\n";
+ EmitClangAttrTemplateInstantiateHelper(Attrs, OS, /*DeclTime=*/false);
+ OS << "}\n\n"
----------------
DeclTime -> AppliesToDecl
================
Comment at: utils/TableGen/ClangAttrEmitter.cpp:2525
+ << " const MultiLevelTemplateArgumentList &TemplateArgs) {\n";
+ EmitClangAttrTemplateInstantiateHelper(Attrs, OS, /*DeclTime=*/true);
+
----------------
DeclTime -> AppliesToDecl
https://reviews.llvm.org/D27486
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
