https://github.com/keith updated https://github.com/llvm/llvm-project/pull/99907
>From 82a1e48e7643b552f898f6866f768a78ea3ba7da Mon Sep 17 00:00:00 2001 From: Keith Smiley <keithbsmi...@gmail.com> Date: Mon, 22 Jul 2024 17:29:46 +0000 Subject: [PATCH 1/2] [clang][test] Add missing test file to cmake Seems like this test was never running with cmake, but is running with bazel and broke at head. --- clang/unittests/Tooling/CMakeLists.txt | 1 + .../Tooling/RecursiveASTVisitorTests/DeductionGuide.cpp | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/clang/unittests/Tooling/CMakeLists.txt b/clang/unittests/Tooling/CMakeLists.txt index 0eb612f8d9498..401978c31863c 100644 --- a/clang/unittests/Tooling/CMakeLists.txt +++ b/clang/unittests/Tooling/CMakeLists.txt @@ -40,6 +40,7 @@ add_clang_unittest(ToolingTests RecursiveASTVisitorTests/CXXMethodDecl.cpp RecursiveASTVisitorTests/CXXOperatorCallExprTraverser.cpp RecursiveASTVisitorTests/DeclRefExpr.cpp + RecursiveASTVisitorTests/DeductionGuide.cpp RecursiveASTVisitorTests/ImplicitCtor.cpp RecursiveASTVisitorTests/ImplicitCtorInitializer.cpp RecursiveASTVisitorTests/InitListExprPostOrder.cpp diff --git a/clang/unittests/Tooling/RecursiveASTVisitorTests/DeductionGuide.cpp b/clang/unittests/Tooling/RecursiveASTVisitorTests/DeductionGuide.cpp index cd4bf0eb7bd5a..27cb39ea8fdf7 100644 --- a/clang/unittests/Tooling/RecursiveASTVisitorTests/DeductionGuide.cpp +++ b/clang/unittests/Tooling/RecursiveASTVisitorTests/DeductionGuide.cpp @@ -58,7 +58,7 @@ Bar s(1); DeductionGuideVisitor::Lang_CXX2a)); } -TEST(RecursiveASTVisitor, DeductionGuideImplicitMode) { +TEST(RecursiveASTVisitor, DISABLED_DeductionGuideImplicitMode) { DeductionGuideVisitor Visitor(/*ShouldVisitImplicitCode*/ true); Visitor.ExpectMatch("Foo(T) -> Foo<int>", 11, 1); Visitor.ExpectMatch("Bar(type-parameter-0-0) -> Foo<int>", 14, 1); >From 82226769a5b1d0b8d19f8968b8b8c1fe3e98f830 Mon Sep 17 00:00:00 2001 From: Keith Smiley <keithbsmi...@gmail.com> Date: Mon, 22 Jul 2024 11:33:57 -0700 Subject: [PATCH 2/2] Discard changes to clang/unittests/Tooling/RecursiveASTVisitorTests/DeductionGuide.cpp --- .../Tooling/RecursiveASTVisitorTests/DeductionGuide.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/clang/unittests/Tooling/RecursiveASTVisitorTests/DeductionGuide.cpp b/clang/unittests/Tooling/RecursiveASTVisitorTests/DeductionGuide.cpp index 27cb39ea8fdf7..cd4bf0eb7bd5a 100644 --- a/clang/unittests/Tooling/RecursiveASTVisitorTests/DeductionGuide.cpp +++ b/clang/unittests/Tooling/RecursiveASTVisitorTests/DeductionGuide.cpp @@ -58,7 +58,7 @@ Bar s(1); DeductionGuideVisitor::Lang_CXX2a)); } -TEST(RecursiveASTVisitor, DISABLED_DeductionGuideImplicitMode) { +TEST(RecursiveASTVisitor, DeductionGuideImplicitMode) { DeductionGuideVisitor Visitor(/*ShouldVisitImplicitCode*/ true); Visitor.ExpectMatch("Foo(T) -> Foo<int>", 11, 1); Visitor.ExpectMatch("Bar(type-parameter-0-0) -> Foo<int>", 14, 1); _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits