https://github.com/martinboehme requested changes to this pull request.

Thanks for taking this on!

Looks good apart from the fact that the test should be in a different file (and 
done slightly differently, see detailed comment in the code).

https://github.com/llvm/llvm-project/pull/99616
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to