llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT--> @llvm/pr-subscribers-clang-modules @llvm/pr-subscribers-clang Author: Dmitry Polukhin (dmpolukhin) <details> <summary>Changes</summary> Summary: These is no sense to report this cases as an error or add `inline` explicitly in this cases. If it is not required in normal headers. Similar to #<!-- -->60079. Test Plan: check-clang --- Full diff: https://github.com/llvm/llvm-project/pull/98309.diff 2 Files Affected: - (modified) clang/lib/Sema/SemaDecl.cpp (+2-1) - (modified) clang/test/CXX/module/module.import/p6.cpp (+10) ``````````diff diff --git a/clang/lib/Sema/SemaDecl.cpp b/clang/lib/Sema/SemaDecl.cpp index b3bfdacb01790..7d810b895f9e8 100644 --- a/clang/lib/Sema/SemaDecl.cpp +++ b/clang/lib/Sema/SemaDecl.cpp @@ -13305,7 +13305,8 @@ void Sema::AddInitializerToDecl(Decl *RealDecl, Expr *Init, bool DirectInit) { if (getLangOpts().CPlusPlusModules && currentModuleIsHeaderUnit() && !VDecl->isInvalidDecl() && VDecl->isThisDeclarationADefinition() && VDecl->getFormalLinkage() == Linkage::External && !VDecl->isInline() && - !VDecl->isTemplated() && !isa<VarTemplateSpecializationDecl>(VDecl)) { + !VDecl->isTemplated() && !isa<VarTemplateSpecializationDecl>(VDecl) && + !VDecl->getInstantiatedFromStaticDataMember()) { Diag(VDecl->getLocation(), diag::err_extern_def_in_header_unit); VDecl->setInvalidDecl(); } diff --git a/clang/test/CXX/module/module.import/p6.cpp b/clang/test/CXX/module/module.import/p6.cpp index 0ed8b5958dffe..cb2d799e5b565 100644 --- a/clang/test/CXX/module/module.import/p6.cpp +++ b/clang/test/CXX/module/module.import/p6.cpp @@ -67,3 +67,13 @@ void* tmpl_fn_ok inline int foo (int a) { return tmpl_OK (a); } + +template <typename T> struct S2 { static int v; }; +template <typename T> int S2<T>::v = 10; + +template <typename T> bool b() { + bool b1 = S2<T>::v == 10; + return b1 && true; +} + +inline bool B = b<int>(); `````````` </details> https://github.com/llvm/llvm-project/pull/98309 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
