https://github.com/jeanPerier approved this pull request.

Looks great!

I guess in most use case only one module file emitted in the compilation unit 
is probably meant to be delivered (while this patch will emit all module file 
of this compilation unit as hermetic), but most app build only define one 
module per compilation unit anyway, so they can set the new -fhermetic-module 
option only for the module file being delivered to avoid heavier builds of 
every intermediate internal module. All that to say, I like the simplicity of 
your solution.

https://github.com/llvm/llvm-project/pull/98083
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to