================
@@ -471,42 +518,123 @@ uint16_t __xray_register_event_type(
 }
 
 XRayPatchingStatus __xray_patch() XRAY_NEVER_INSTRUMENT {
-  return controlPatching(true);
+  XRayPatchingStatus CombinedStatus{SUCCESS};
----------------
sebastiankreutzer wrote:
I would argue yes, since in this case doing nothing would be the expected 
behavior. 
However, in practice this case should never occur because the executable itself 
is always "loaded".

We could add an assertion to make this assumption explicit. What do you think?



https://github.com/llvm/llvm-project/pull/90959
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to