hokein added inline comments.
================
Comment at: change-namespace/ChangeNamespace.cpp:719
+ // The alias is defined in some namespace.
+ assert(AliasQualifiedName.size() >= AliasName.size() + 2);
+ llvm::StringRef AliasNs =
----------------
maybe `assert(StringRef(AliasQualifiedName).end_with("::"+AliasName))`?
================
Comment at: change-namespace/ChangeNamespace.cpp:741
if (TargetDecl == FromDecl) {
ReplaceName = FromDecl->getNameAsString();
Matched = true;
----------------
Do we also need to check `FromDecl->getNameAsString().size() <
ReplaceName.size()` before assigning the name to `ReplaceName`?
================
Comment at: unittests/change-namespace/ChangeNamespaceTests.cpp:832
+ "}\n"
+ "namespace gl = glob;\n"
+ "namespace na {\n"
----------------
Add a testcase for the namespace alias decl with preceding `::`, e.g.
`namespace gl = ::glob`?
https://reviews.llvm.org/D28052
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
