klimek accepted this revision. klimek added a comment. This revision is now accepted and ready to land.
Apart from the error handling LG. Thanks! ================ Comment at: lib/Format/Format.cpp:1920-1922 + std::error_code EC = FS->makeAbsolute(Path); + assert(!EC); + (void)EC; ---------------- I think if makeAbsolute doesn't work, we will probably want to err out here: if (EC) { llvm::errs() << ... << EC.message << ... return Style; } https://reviews.llvm.org/D27971 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits