aaron.ballman added a comment.

I still think that this looks good, so if @rsmith doesn't comment over the 
weekend, you can go ahead and commit on Monday -- we can handle any feedback in 
post-commit review.



================
Comment at: include/clang/Basic/AttrDocs.td:240
+  Specifically, clang will only trace ``const`` pointers (as above); we give up
+  on pointers that are not marked as ``const``.  In the vast majority of cases,
+  this is unimportant, because LLVM has support for the ``alloc_size``
----------------
Double space after the full stop should be a single space (here and below).


https://reviews.llvm.org/D14274



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D14274: Add allo... Aaron Ballman via Phabricator via cfe-commits

Reply via email to