================
@@ -9219,7 +9222,8 @@ class Sema final : public SemaBase {
   /// \returns true if an error occurred, false otherwise.
   bool CheckTemplateArgumentList(
       TemplateDecl *Template, SourceLocation TemplateLoc,
-      TemplateArgumentListInfo &TemplateArgs, bool PartialTemplateArgs,
+      TemplateArgumentListInfo &TemplateArgs,
----------------
mizvekov wrote:

Yeah. One issue I have often had with these functions with large amount of both 
defaulted and non-defaulted parameters, is that you would want to extend it by 
changing the signature, then arguments would match parameters incorrectly, but 
this would not cause a hard error on all of the call sites.

I could have easily added DefaultArgs as defaulted empty here, but chose not to 
due to this reason.

Besides that, overloading functions with such huge numbers of parameters 
creates some confusion as well.
I'd slightly prefer if we avoided that, but don't have strong enough feelings 
to go on a crusade against it.

https://github.com/llvm/llvm-project/pull/94981
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to