https://github.com/llvm-beanz approved this pull request.

I think dependencies for object libraries are implicitly `INTERAFCE`, but it 
might be nice to make that explicit. I know CMake complains if you mix and 
match implicit and explicit specification of linkage types.

Otherwise LGTM.

https://github.com/llvm/llvm-project/pull/93454
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to