alexfh added a comment. LG with one nit. Feel free to ping earlier next time.
================ Comment at: clang-tidy/misc/SuspiciousEnumUsageCheck.cpp:170-171 + if (const auto *EnumExpr = Result.Nodes.getNodeAs<Expr>("enumExpr")) { + if (!StrictMode) + return; + const auto *EnumDec = Result.Nodes.getNodeAs<EnumDecl>("enumDecl"); ---------------- Looks like this is the same as in case 3 below, so you could just move this check out of the branch and remove the duplication below. https://reviews.llvm.org/D22507 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits