JonasToth marked an inline comment as done. JonasToth added inline comments.
================ Comment at: docs/clang-tidy/checks/cppcoreguidelines-no-malloc.rst:10 +See `C++ Core Guidelines +<https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#r-resource-management>` + ---------------- malcolm.parsons wrote: > Do you mean `#r10-avoid-malloc-and-free`? yes, but i think the wider view is more appropriate. RAII is a general strategy, and not specific to malloc etc. ================ Comment at: docs/clang-tidy/checks/cppcoreguidelines-no-malloc.rst:26 + // Rather use a smartpointer or stack variable. + struct some_struct* = (struct some_struct*) malloc(sizeof(struct some_struct)); + ---------------- malcolm.parsons wrote: > Missing variable. that slipped through. i fix it. Repository: rL LLVM https://reviews.llvm.org/D26167 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
