martinboehme wrote: > @martinboehme hello Martin, I resurrected your change at > https://reviews.llvm.org/D145581?id=503330#inline-1406063 and posted here in > hope that we can continue your efforts and finally land the change in the > main branch. Hope you don't mind that I created this PR without your > permissions.
No, not at all. On the contrary -- thanks for picking up this change that I let go stale. > We are also using clang-tidy in our project. Since we are using the chained > expression like `v.foo(x, y).then(std::move(x)).then(std::move(v))` a lot, > it's a little bit annoying that clang-tidy warns at seeing this. These false > alarms reduce the signal-to-noise ratio of the output of this tool. > > On top of your change, I made following changes > > [snip] > > these changes are collected in a separate commit in this PR, if you are good > with them, I will fold it into the first commit, and then mark this PR > ready-for-review. Yes, those changes look good to me. Thanks! https://github.com/llvm/llvm-project/pull/93623 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
