================
@@ -368,7 +368,8 @@ CodeGenModule::CodeGenModule(ASTContext &C,
   IntTy = llvm::IntegerType::get(LLVMContext, C.getTargetInfo().getIntWidth());
   IntPtrTy = llvm::IntegerType::get(LLVMContext,
     C.getTargetInfo().getMaxPointerWidth());
-  Int8PtrTy = llvm::PointerType::get(LLVMContext, 0);
+  Int8PtrTy = llvm::PointerType::get(LLVMContext,
----------------
AlexVlx wrote:

> Fixing emitUsed probably is a feasible solution, but GlobalsInt8PtrTy will 
> cause the used array containing pointers to addr space 1, which is not 
> backward compatible for HIP. Maybe just use pointer to addr space 0 type as 
> before.

This would be wrong, assuming that 0 / Unqual is generally equivalent with some 
form of generic pointer is the core problem here. I'm not exactly sure what you 
mean by "backward compatible" here though, both the HIP source and whatever BC 
gets linked should go through the same toolchain, surely? Also, what @arsenm 
said sounds about right.

https://github.com/llvm/llvm-project/pull/88182
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to