jlebar accepted this revision.
jlebar added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lib/Driver/Driver.cpp:1952
+
+
+      // Default to sm_20 which is the lowest common denominator for
----------------
Extra linebreak


================
Comment at: lib/Driver/Driver.cpp:1960
+        // Sort GpuArchList to make compilation order deterministic.
+        std::sort(GpuArchList.begin(), GpuArchList.end());
 
----------------
We're using std::set, so I don't think this is necessary?  You could have a 
comment on std::set saying that we use it to get a deterministic order, if you 
want.


================
Comment at: test/Driver/cuda-options.cu:154
+
+
 // Match device-side preprocessor and compiler phases with -save-temps.
----------------
Extra linebreak


https://reviews.llvm.org/D27631



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to