dcoughlin added inline comments.
================ Comment at: lib/StaticAnalyzer/Checkers/ObjCPropertyChecker.cpp:44 + BugReporter &BR) const { + if (D->isReadOnly() || D->getSetterKind() != ObjCPropertyDecl::Copy) + return; ---------------- It is probably worth adding a test that the checker still issues a diagnostic when a readonly property in the primary interface is 'shadowed' by a readwrite property in a class extension. This is a very common idiom which lets the programmer expose the property as readonly in public but readwrite in private. https://reviews.llvm.org/D27535 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits