erichkeane marked an inline comment as done.
erichkeane added inline comments.
================
Comment at: lib/CodeGen/TargetInfo.cpp:1688
+ for (auto &I : FI.arguments()) {
+ if(Count < 6)
+ I.info = reclassifyHvaArgType(I.type, State, I.info);
----------------
majnemer wrote:
> Formatting.
I don't see what you mean? This area went through clang-format? What did I
miss?
================
Comment at: lib/CodeGen/TargetInfo.cpp:3871
+ for (auto &I : FI.arguments()) {
+ if (Count < 6)
+ I.info = classify(I.type, FreeSSERegs, false, IsVectorCall, IsRegCall);
----------------
majnemer wrote:
> majnemer wrote:
> > And here,
> I was OK with `6` showing up in prior code because there was a comment but
> there isn't such a comment down here. Maybe we should have this `6` live in
> an enum?
Thats a good point. Any reason it couldn't just be a static constant in each
of the ABIInfos? Or am I missing your point?
https://reviews.llvm.org/D27529
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
