[PATCH] D24218: [libc++] Fix support for multibyte thousands_sep and decimal_point in moneypunct_byname and numpunct_byname.

[Eric van Gyzen via Phabricator via cfe-commits]

vangyzen added inline comments.


================
Comment at: src/locale.cpp:4339
         if (loc == nullptr)
             __throw_runtime_error("numpunct_byname<char>::numpunct_byname"
                                 " failed to construct for " + string(nm));
----------------
While you're here, you might change `char` to `wchar_t`.


================
Comment at: src/locale.cpp:4348
         __grouping_ = lc->grouping;
         // locallization for truename and falsename is not available
     }
----------------
Maybe fix the spelling of "localization".


https://reviews.llvm.org/D24218



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits