rengolin added inline comments.

================
Comment at: test/Driver/linux-ld.c:1016
+// CHECK-LD-GENTOO-ARMHF: "-dynamic-linker" "/lib/ld-linux-armhf.so.3"
+// CHECK-LD-GENTOO-ARMHF: 
"{{.*}}/usr/lib/gcc/armv7a-hardfloat-linux-gnueabi/4.9.3/crtbegin.o"
+// CHECK-LD-GENTOO-ARMHF: 
"-L[[SYSROOT]]/usr/lib/gcc/armv7a-hardfloat-linux-gnueabi/4.9.3"
----------------
mgorny wrote:
> rengolin wrote:
> > mgorny wrote:
> > > rengolin wrote:
> > > > where is 4.9.3 coming from?
> > > It's the version used in the input tree, i.e. the two added files above.
> > Right, I mean is this "4.9.3" there because the driver "found" it there, or 
> > is it generated by the compiler version you have on your machine, and 
> > that's why you created the directory with "4.9.3" in it?
> > 
> > I'm worried that if it's the latter, the test will fail on any machine that 
> > doesn't have that compiler version. But I really don't know how it works, 
> > so it was an honest question. :)
> It's there because Driver founds it in Input directory structure. I don't 
> have that version installed locally, if that's what worries you. You could 
> say it's intentionally different from my install but I've simply copied the 
> version used by other Gentoo tests.
That answers my question, thanks! :)


https://reviews.llvm.org/D25686



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to