[PATCH] D27066: Fix crash with unsupported architectures in Linux/Gnu target triples.

[Joerg Sonnenberger via Phabricator via cfe-commits]

joerg accepted this revision.
joerg added a reviewer: joerg.
joerg added a comment.

LGTM with a small cleanup.



================
Comment at: lib/Driver/Tools.cpp:10018
+  const char *LDMOption = getLDMOption(ToolChain.getTriple(), Args);
+  if (!LDMOption) {
+    D.Diag(diag::err_target_unknown_triple) << Triple.str();
----------------
Please write this as
```
   if (const char *LDMOption = ...) {
     ...
  } else {
     D.Diag(...);
     return;
  }
```


https://reviews.llvm.org/D27066



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits