================ @@ -2824,8 +2827,12 @@ bool RISCVAsmParser::parseDirectiveOption() { break; } - auto Ext = llvm::lower_bound(RISCVFeatureKV, Arch); - if (Ext == std::end(RISCVFeatureKV) || StringRef(Ext->Key) != Arch || + std::string &&Feature = RISCVISAInfo::getTargetFeatureForExtension(Arch); ---------------- topperc wrote:
I think you should just use `std::string Feature`. I think `std::string &&Feature` will just make a reference to a hidden temporary object. https://github.com/llvm/llvm-project/pull/89727 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits