mclow.lists accepted this revision.
mclow.lists added a comment.
This revision is now accepted and ready to land.
Other than the missing `assert`s, (which are not your fault, but I would
appreciate you fixing) this LGTM.
================
Comment at: test/std/containers/sequences/array/at.pass.cpp:43
+#ifndef TEST_HAS_NO_EXCEPTIONS
try { (void) c.at(3); }
catch (const std::out_of_range &) {}
----------------
we should really have an `assert(false);` after the call to `at` - to make sure
that it actually throws.
Here and below.
https://reviews.llvm.org/D27095
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
