[PATCH] D27109: [OpenCL] Prevent generation of globals in non-constant address space for OpenCL

[Yaxun Liu via Phabricator via cfe-commits]

yaxunl added inline comments.


================
Comment at: lib/CodeGen/CGDecl.cpp:954
+      if (!getLangOpts().OpenCL || Ty.getAddressSpace() == 
LangAS::opencl_constant)
+        if (CGM.getCodeGenOpts().MergeAllConstants && !NRVO && !isByRef &&
+            CGM.isTypeConstant(Ty, true)) {
----------------
can we merge this if with the above if?


https://reviews.llvm.org/D27109



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits