mclow.lists added a comment. Tests look good; I'm still staring at the stuff in `<__string>`.
================ Comment at: include/__string:138 template <class _CharT> -inline -const _CharT* +_LIBCPP_CONSTEXPR_AFTER_CXX14 inline const _CharT* char_traits<_CharT>::find(const char_type* __s, size_t __n, const char_type& __a) ---------------- Let's pick an order and stick to it. Either `_LIBCPP_CONSTEXPR_AFTER_CXX14 inline` (as we use here) or `inline _LIBCPP_CONSTEXPR_AFTER_CXX14` (as we use on L#204) I prefer `inline _LIBCPP_CONSTEXPR_AFTER_CXX14`. https://reviews.llvm.org/D26896 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
