yamt wrote: > I'm not sure about the common practice in this repo, but Github in general > supports merge workflows much better. Especially in a long-running large PRs, > if you force-push, it's hard for the reviewers to know what has changed since > their last review, because all the history his lost and they have to look at > the whole diff again. And many PRs in this repo tend to be bigger and > long-running than other repos in my opinion. > > Also Github supports a nice feature called "New changed since you last > reviewed" >  > and this feature is usable only with the merge workflow. (The screenshot is > not mine; I got it from Google) I wonder why the merge workflow is harder to > review. > > Also when you merge a PR, you do "squash and merge", so all those merge > commits are not gonna end up in the main branch because they are squashed > into a single commit, so you don't need to worry about that. (If you do > "Create a merge commit" the story is different but that option is not enabled > for this repo and I don't think it's used often elsewhere either)
Ok. Maybe it's fine for projects like this, where we squash commits when landing. https://github.com/llvm/llvm-project/pull/84137 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
