bader accepted this revision.
bader added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks!
A few minor comments regarding outdated comments and style.
================
Comment at: include/clang/AST/ASTContext.h:1124
/// \brief Return pipe type for the specified type.
+ QualType getReadPipeType(QualType T) const;
----------------
Please, update the comment to specify that this function return pipe type with
'__read_only' access qualifier.
================
Comment at: lib/AST/ASTContext.cpp:3341
/// Return pipe type for the specified type.
+QualType ASTContext::getReadPipeType(QualType T) const {
----------------
Please, remove this comment. It's a copy of the comment from the header file.
================
Comment at: lib/Serialization/ASTReader.cpp:5806-5807
+ return Context.getReadPipeType(ElementType);
+ }
+ case TYPE_WRITE_PIPE: {
+ if (Record.size() != 1) {
----------------
Please, separate case with an empty line.
Repository:
rL LLVM
https://reviews.llvm.org/D26746
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
