rsmith added a comment.

This is causing warnings to fire for headers shared between C and C++, where 
the "give the enum an unsigned underlying type" advice doesn't work, and where 
the code in question will never be built for the MS ABI. It seems really hard 
to justify this being on by default.

I'm going to turn it off by default for now, but we should probably consider 
turning it back on by default when targeting the MS ABI (as a "your code is 
wrong" warning rather than a "your code is not portable" warning).


Repository:
  rL LLVM

https://reviews.llvm.org/D24289



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to