https://github.com/PiotrZSL approved this pull request.
First this null-ptr check does nothing because in line 114 we still missing nullptr check. Proper way would be to "return" when we find nullptr were it shoudnt. Second thing, asserts mean nothing. In release mode they are disabled. This mean that if we get nullptr, then we going to crash. Change is fine for me, but not because there is assert but because in line 114 dereference will happened anyway. https://github.com/llvm/llvm-project/pull/85473 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
