Timm =?utf-8?q?Bäder?= <tbae...@redhat.com>, Timm =?utf-8?q?Bäder?= <tbae...@redhat.com> Message-ID: In-Reply-To: <llvm.org/llvm/llvm-project/pull/83...@github.com>
tbaederr wrote: > Sorry, I thought you were still doing some investigation. Ah, sorry, I was just trying to say that this is how far I'm going to investigate at that point. :) > I can live with either approach; the CRTP way doesn't seem too awful to me > and retains the separation. But the unified interface also doesn't seem too > awful to me given the relationship between `Stmt` and `Expr` in our AST. > Given your preference for the unified interface, I'd be okay moving forward > with that. I would probably merge them but then split the implementation into different files, e.g. one for common expressions, one for statements, but also one for `_Complex` stuff, etc. Does that sound better? https://github.com/llvm/llvm-project/pull/83683 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
