hokein added inline comments.

================
Comment at: clang-move/ClangMove.cpp:144
+  void run(const ast_matchers::MatchFinder::MatchResult &Result) override {
+    if (const auto *CMD =
+            Result.Nodes.getNodeAs<clang::CXXMethodDecl>("class_method")) {
----------------
ioeric wrote:
> It'd be more readable if you pull each case below into a helper function.
hmm, I'd prefer current way. Because I don't see significant advantage by 
pulling each case into a helper function, since the code for each condition is 
used only once. 
 


https://reviews.llvm.org/D26515



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to