AaronBallman wrote:

> Since this is a relatively benign bug, all things considered, does this even 
> warrant a release note?

I think it should have a release note; it changes the layout of the AST which 
may impact folks writing AST matchers (clang-tidy checks, etc). But also, I 
think it does fix #31205 which is worth mentioning as users can notice the 
performance difference on multiplication and division (not so much on addition 
or subtraction, I believe).

I think the code is correct and the extra test coverage is awesome, but I've 
added @jcranmer-intel as a reviewer to double check that everything is correct.



https://github.com/llvm/llvm-project/pull/83063
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to