aeubanks wrote: > FWIW we've tried this with sampling PGO in the past. While on paper this > seems like an obvious thing to do, in reality aggressively tuning down opt > level for cold functions can lead to regression since profile isn't always > accurate. > > That said, as long as this change only provides options for users to make > decision and not changing the default behavior, it's probably fine.
IIUC, this won't affect sample profile unless you mark the sample profile as "accurate" (e.g. `-profile-sample-accurate`). But I should double check. https://github.com/llvm/llvm-project/pull/69030 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
