arsenm added inline comments.
================ Comment at: test/CodeGenOpenCL/amdgpu-nullptr.cl:49 +} + ---------------- I think there need to be a lot more tests. A few I can think of: - Tests that compare to NULL instead of 0 - Pointer compares without the explicit 0, i.e. if (p)/if(!p) - Storage of a pointer value - Calls with a pointer argument - Set of tests with constant address space pointers - Cast null to integer - Compare of null with null - Compare null in one address space with null in another https://reviews.llvm.org/D26196 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
