aaron.ballman added a comment.

Does this check properly work in the presence of macros? Those are sometimes 
more common in casting operations, so a few explicit tests would be good (those 
tests could be follow-on work if it turns out that this check doesn't play 
nicely with macros).



================
Comment at: clang-tidy/modernize/UseAutoCheck.cpp:404
+                [](const Expr *Expr) { return Expr->getType(); },
+                "use auto when initializing with new to avoid "
+                "duplicating the type name");
----------------
Quote use of `auto` and `new` in the diagnostic since they're syntax rather 
than english.


================
Comment at: clang-tidy/modernize/UseAutoCheck.cpp:413
+        },
+        "use auto when initializing with a cast to avoid duplicating the type "
+        "name");
----------------
Same here.


Repository:
  rL LLVM

https://reviews.llvm.org/D25316



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to