EricWF added inline comments.

================
Comment at: CMakeLists.txt:117
 option(LIBCXXABI_ENABLE_WERROR "Fail and stop if a warning is triggered." OFF)
 option(LIBCXXABI_USE_LLVM_UNWINDER "Build and use the LLVM unwinder." OFF)
 option(LIBCXXABI_USE_COMPILER_RT "Use compiler-rt instead of libgcc" OFF)
----------------
EricWF wrote:
> ```
> cmake_dependent_option(LIBCXXABI_USE_LLVM_UNWINDER "Build and use the LLVM 
> unwinder" OFF
>                                            "LLVM_NATIVE_ARCH MATCHES ARM" ON)
> ```
> 
> And don't forget to add the include for cmake_dependent_option somewhere 
> above!
The above code isn't correct as-is. You'll have to escape the strings for 
MATCHES.


https://reviews.llvm.org/D24082



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to