https://github.com/banach-space approved this pull request.

> Intended to warn users of the 19.x release not to do this.
> 
> A better solution should be found for the 20.x release. See discussion in 
> https://github.com/llvm/llvm-project/pull/78152.
> 
> Unfortunately there is no warning on Windows currently. I am rushing to get 
> this landed before 19.x branches.

Did you mean:

> Intended to warn users of the 18.x release not to do this.
> 
> A better solution should be found for the 19.x release. See discussion in 
> https://github.com/llvm/llvm-project/pull/78152.
> 
> Unfortunately there is no warning on Windows currently. I am rushing to get 
> this landed before 19.x branches.

LGTM modulo a few comments. I like this direction!

https://github.com/llvm/llvm-project/pull/79016
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to