aaron.ballman added a comment. clang-tidy/cert/.LimitedRandomnessCheck.cpp.swo was added and should not have been; also, there's one minor issue with the diagnostic wording that is still outstanding.
================ Comment at: clang-tidy/cert/LimitedRandomnessCheck.cpp:35 + diag(MatchedDecl->getLocStart(), + "rand() function has limited randomness; " + msg); +} ---------------- aaron.ballman wrote: > For C code, this diagnostic will read strangely due to the trailing > semicolon. You should move the semicolon into the `msg` above. Perhaps we can > also drop "function" from the diagnostic as well. This comment does not appear to have been handled -- the semicolon is still present even when `msg` is empty. https://reviews.llvm.org/D22346 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
