================ @@ -0,0 +1,132 @@ +//===--- UseStdMinMaxCheck.cpp - clang-tidy -------------------------------===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception +// +//===----------------------------------------------------------------------===// + +#include "UseStdMinMaxCheck.h" +#include "../utils/ASTUtils.h" +#include "clang/AST/ASTContext.h" +#include "clang/ASTMatchers/ASTMatchFinder.h" +#include "clang/Lex/Preprocessor.h" +#include <optional> + +using namespace clang::ast_matchers; + +namespace clang::tidy::readability { + +UseStdMinMaxCheck::UseStdMinMaxCheck(StringRef Name, ClangTidyContext *Context) + : ClangTidyCheck(Name, Context), + IncludeInserter(Options.getLocalOrGlobal("IncludeStyle", + utils::IncludeSorter::IS_LLVM), + areDiagsSelfContained()), + AlgorithmHeader(Options.get("AlgorithmHeader", "<algorithm>")) {} + +void UseStdMinMaxCheck::storeOptions(ClangTidyOptions::OptionMap &Opts) { + Options.store(Opts, "IncludeStyle", IncludeInserter.getStyle()); +} + +void UseStdMinMaxCheck::registerMatchers(MatchFinder *Finder) { + Finder->addMatcher( + ifStmt( + has(binaryOperator( + anyOf(hasOperatorName("<"), hasOperatorName(">"), + hasOperatorName("<="), hasOperatorName(">=")), + hasLHS(expr().bind("lhsVar1")), hasRHS(expr().bind("rhsVar1")))), + hasThen( + anyOf(stmt(binaryOperator(hasOperatorName("="), + hasLHS(expr().bind("lhsVar2")), + hasRHS(expr().bind("rhsVar2")))), + compoundStmt(has(binaryOperator( + hasOperatorName("="), hasLHS(expr().bind("lhsVar2")), + hasRHS(expr().bind("rhsVar2")))))))) + .bind("ifStmt"), + this); +} + +void UseStdMinMaxCheck::registerPPCallbacks(const SourceManager &SM, + Preprocessor *PP, + Preprocessor *ModuleExpanderPP) { + IncludeInserter.registerPreprocessor(PP); +} + +void UseStdMinMaxCheck::check(const MatchFinder::MatchResult &Result) { + const auto *lhsVar1 = Result.Nodes.getNodeAs<Expr>("lhsVar1"); + const auto *rhsVar1 = Result.Nodes.getNodeAs<Expr>("rhsVar1"); + const auto *lhsVar2 = Result.Nodes.getNodeAs<Expr>("lhsVar2"); + const auto *rhsVar2 = Result.Nodes.getNodeAs<Expr>("rhsVar2"); + const auto *ifStmt = Result.Nodes.getNodeAs<IfStmt>("ifStmt"); + auto &Context = *Result.Context; + const SourceManager &Source = Context.getSourceManager(); + + if (!lhsVar1 || !rhsVar1 || !lhsVar2 || !rhsVar2 || !ifStmt) + return; + + const auto *binaryOp = dyn_cast<BinaryOperator>(ifStmt->getCond()); + if (!binaryOp) + return; + + SourceLocation ifLocation = ifStmt->getIfLoc(); + SourceLocation thenLocation = ifStmt->getEndLoc(); + + auto lhsVar1Str = + Lexer::getSourceText(Source.getExpansionRange(lhsVar1->getSourceRange()), + Context.getSourceManager(), Context.getLangOpts()); + + auto lhsVar2Str = + Lexer::getSourceText(Source.getExpansionRange(lhsVar2->getSourceRange()), + Context.getSourceManager(), Context.getLangOpts()); + + auto rhsVar1Str = + Lexer::getSourceText(Source.getExpansionRange(rhsVar1->getSourceRange()), + Context.getSourceManager(), Context.getLangOpts()); + + auto replacementMax = lhsVar2Str.str() + " = std::max(" + lhsVar1Str.str() + + ", " + rhsVar1Str.str() + ");"; + auto replacementMin = lhsVar2Str.str() + " = std::min(" + lhsVar1Str.str() + + ", " + rhsVar1Str.str() + ");"; + auto *operatorStr = binaryOp->getOpcodeStr().data(); ---------------- 5chmidti wrote:
There is no need to call `data` here, `getOpcodeStr` returns a `StringRef` that can be streamed into the diagnostic like you currently are with this `const char*` https://github.com/llvm/llvm-project/pull/77816 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
