================
@@ -568,32 +590,45 @@ void createRegisterFatbinFunction(Module &M,
GlobalVariable *FatbinDesc,
} // namespace
-Error wrapOpenMPBinaries(Module &M, ArrayRef<ArrayRef<char>> Images) {
- GlobalVariable *Desc = createBinDesc(M, Images);
+Error OffloadWrapper::wrapOpenMPBinaries(
+ Module &M, ArrayRef<ArrayRef<char>> Images,
+ std::optional<EntryArrayTy> EntryArray) const {
+ GlobalVariable *Desc = createBinDesc(
+ M, Images,
+ EntryArray
+ ? *EntryArray
+ : offloading::getOffloadEntryArray(M, "omp_offloading_entries"),
----------------
jhuber6 wrote:
Thinking that this argument shouldn't be default, it should be up to whoever
calls it to create such an array. For the linker wrapper it would be getting
the offloading utility first. Making these arrays is quite complicated for
implicit default behavior if we're expecting other things to happen I feel.
https://github.com/llvm/llvm-project/pull/78057
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
