WenleiHe wrote: > Agreed with this concern. To do this, we probably also need a flag in the > binary, because otherwise if we use the new toolchain for prof-gen but the > binary built on the old toolchain, we then would generate a profile with this > flag on but the order is the old one. My understanding is the (probe) version > of profile should line up with the version of the binary. Maybe make this > more general, we can introduce a "pseudo_probe_version" thing, similar to > instrPGO > https://github.com/llvm/llvm-project/blob/main/llvm/include/llvm/ProfileData/InstrProf.h#L996 > . It can be useful if we want to update other pseudo probe formats in future.
Versioning is one way to do this. Alternatively, we should be able to detect the case during llvm-profgen time when all call site probe and block probe ids are separated, which can then be used to set flags? https://github.com/llvm/llvm-project/pull/75092 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
