aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land.
LGTM ================ Comment at: clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp:30 +AST_MATCHER(CXXRecordDecl, hasDefaultConstructor) { + return Node.hasDefaultConstructor(); ---------------- I think this should be a public AST matcher rather than a private one; it seems like it would be generally useful (along with some of the other similar has* functions). However, I think it's fine for this patch. https://reviews.llvm.org/D25747 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits