kadircet wrote: > This change makes sense for removing all unused includes (as all these unused > includes are visible in the editor). For missing includes, they are less > obvious, but it is probably fine.
The rationale for missing includes was the same, when things go wrong it's usually obscure enough that problems only raise with build systems that have visibility restrictions. Hence I am not sure if this extra step provides enough value. > (I think it would be great to have a way to view all missing includes, VSCode > has a feature to preview code action changes, but it seems > [broken](https://github.com/clangd/vscode-clangd/issues/376) with clangd.) Agreed, making alt+enter work in these cases would be useful, and last time I checked it is actually working. I tried with this patch, and it still gives people a way to preview and selectively apply these edits. So we're actually not taking away the functionality completely, but rather putting this behind an extra shortcut :) Can you check if it's still broken for you ? <img width="618" alt="Screenshot 2024-01-04 at 12 52 20" src="https://github.com/llvm/llvm-project/assets/897555/afe76b42-1ed4-4612-9d83-5499baf90119";> https://github.com/llvm/llvm-project/pull/76826 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
