https://github.com/EricWF approved this pull request.
LGTM. I see @var-const has "requested changes" set, but I feel we've addressed the one unresolved comment of his. Given the amount of work you're going to be doing in the new year adding more fold algorithms, this code is going to get a lot of love still yet. Any concerns that haven't been satisfactorily addressed will certainly be addressed in those reviews, if not earlier. I would like for this change to land, before we all have such good holidays that we forget all about it. @cjdb Without further input from @var-const , I believe you should commit this change. As long as your willing to work diligently to resolve any post-commit feedback that occurs. https://github.com/llvm/llvm-project/pull/75259 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
