================
@@ -113,7 +113,7 @@ class PragmaIncludes {
   llvm::DenseSet<llvm::sys::fs::UniqueID> ShouldKeep;
 
   /// Owns the strings.
-  llvm::BumpPtrAllocator Arena;
+  std::shared_ptr<llvm::BumpPtrAllocator> Arena;
----------------
sam-mccall wrote:

This doesn't look threadsafe. Two PIs associated with parallel ParsedAST builds 
will write into the same arena.

You could do some trick with shared_ptr<void> to keep all needed arenas alive, 
and a raw pointer to the current, I guess?

https://github.com/llvm/llvm-project/pull/75612
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to