zmodem wrote:

Thanks for looking at this. Silently ignoring bad inputs is usually not a good 
idea.

However, it would seem better to emit a proper diagnostic from the driver 
rather than calling exit in getOSDefines(). That way the regular diagnostic 
mechanisms can be used to decide what to do with it (treat as error, ignore, 
etc.).

https://github.com/llvm/llvm-project/pull/75373
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to