================
@@ -1,39 +1,45 @@
-; Do setup work for all below tests: generate bitcode and combined index
-; RUN: opt -module-summary %s -o %t.bc
-; RUN: opt -module-summary %p/Inputs/thinlto_indirect_call_promotion.ll -o 
%t2.bc
+; The raw profiles and reduced IR inputs are generated from 
Inputs/update_icall_promotion_inputs.sh
----------------
ellishg wrote:

I don't think there should be any sharing between `llvm/test` and 
`compiler-rt/test`. As you can see in `instrprof-basic.c`, it generates raw 
profiles and then generates and checks the IR to make sure profile data is 
consumed.

`compiler-rt/test` is useful if we need to run code, but it doesn't run on all 
platforms. If you only need to check IR, it is better to put the test in 
`llvm/test`. That being said, I wonder if it makes sense to split this into two 
tests. One in `compiler-rt/test` to make sure raw profiles are generated and 
consumed correctly, and verifying some IR. The other in `llvm/test` to make 
sure that IR is correct using a `.proftext` file, which can be tested quickly.

https://github.com/llvm/llvm-project/pull/74008
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to