aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.
Aside from some minor nits, the attribute functionality looks fine to me. As to
whether we think this is a worthy attribute to add or not, I leave that to
people who know CUDA and OpenCL better than I do, so please wait for
@tstellarAMD or @Anastasia to sign off before committing.
================
Comment at: include/clang/Basic/AttrDocs.td:612
+ let Content = [{
+The ``convergent`` attribute can be placed on function declarations. It is
+translated to LLVM ``convergent`` attribute, which indicates the call
----------------
aaron.ballman wrote:
> on a function declaration
"declarations" should be singular (declaration).
================
Comment at: test/SemaOpenCL/convergent.cl:1
+// RUN: %clang_cc1 -triple spir-unknown-unknown -verify %s
+
----------------
Should add `-fsyntax-only` to the test.
https://reviews.llvm.org/D25343
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
