arphaman added a comment.
> I'm unsure about whether or not the CodeGenPGO change in this patch deserves
> more testing.
It wouldn't harm to add a test for CodeGenPGO as well. A good test that you can
as a starting point for the new one is `test/Profile/cxx-rangefor.cpp`. A
single `PGOGEN` check for a PGO counter generated from a subexpression in a
switch initializer should be sufficient.
================
Comment at: lib/CodeGen/CoverageMappingGen.cpp:818
+ Visit(S->getInit());
+
Visit(S->getCond());
----------------
I noticed that you added a newline here, wouldn't it be better to have it after
`extendRegion(S)` so that the `Visit` calls are grouped together?
https://reviews.llvm.org/D25539
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
